On 03/11/2022 10.54, Akihiko Odaki wrote:
The register definitions in tests/qtest/e1000e-test.c had names
different from hw/net/e1000_regs.h, which made it hard to understand
what test codes corresponds to the implementation. Use
hw/net/e1000_regs.h from tests/qtest/libqos/e1000e.c to remove
these duplications.

Signed-off-by: Akihiko Odaki <akihiko.od...@daynix.com>
---
  tests/qtest/e1000e-test.c | 66 ++++++---------------------------------
  1 file changed, 10 insertions(+), 56 deletions(-)

diff --git a/tests/qtest/e1000e-test.c b/tests/qtest/e1000e-test.c
index c98779c7c0..9e7cb1eb2d 100644
--- a/tests/qtest/e1000e-test.c
+++ b/tests/qtest/e1000e-test.c
@@ -33,34 +33,11 @@
  #include "qemu/bitops.h"
  #include "libqos/malloc.h"

 Hi!

Thank you for your patches! Just a very small nit: That "libqos/malloc.h" was still old context, the file is called "libqos/libqos-malloc.h" now - please make sure to send patches based on the latest git master branch. Anyway, it was trivial to fix up, so I've queued your patch now (together with your three other patches) to my testing-next branch:

 https://gitlab.com/thuth/qemu/-/commits/testing-next

 Thomas


Reply via email to