On Sun, Oct 30, 2022 at 09:48:08PM +0530, Ani Sinha wrote: > > > On Sun, 30 Oct 2022, Michael S. Tsirkin wrote: > > > On Sun, Oct 30, 2022 at 09:15:44PM +0530, Ani Sinha wrote: > > > > > > > > > On Sat, 29 Oct 2022, Michael S. Tsirkin wrote: > > > > > > > On Fri, Oct 28, 2022 at 10:18:43PM +0530, Ani Sinha wrote: > > > > > On Fri, Oct 28, 2022 at 9:45 PM B <shen...@gmail.com> wrote: > > > > > > > > > > > > > > > > > > > > > > > > Am 28. Oktober 2022 10:58:07 UTC schrieb Ani Sinha > > > > > > <a...@anisinha.ca>: > > > > > > >On Fri, Oct 28, 2022 at 4:05 PM Bernhard Beschow > > > > > > ><shen...@gmail.com> wrote: > > > > > > >> > > > > > > >> The code currently assumes Q35 iff ICH9 and i440fx iff PIIX. Now > > > > > > >> that more > > > > > > >> AML generation has been moved into the south bridges and since > > > > > > >> the > > > > > > >> machines define themselves primarily through their north > > > > > > >> bridges, let's > > > > > > >> switch to resolving the north bridges for AML generation > > > > > > >> instead. This > > > > > > >> also allows for easier experimentation with different south > > > > > > >> bridges in > > > > > > >> the "pc" machine, e.g. with PIIX4 and VT82xx. > > > > > > > > > > > > > >Unfortunately this patch does not apply on the latest master. Also > > > > > > >the > > > > > > >code seems to be off. Can you rebase and rework the patch? > > > > > > > > > > > > I've rebased onto Igor's series to avoid merge conflicts, > > > > > > > > > > Ok I will let Igor deal with this then since I have not followed his > > > > > patchset. > > > > > > > > should you want to review this, it's all in my tree right now. > > > > > > I tried your "next" branch from > > > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git > > > > > > and it does not apply there either. > > > > > > commit 87bbbe87c259414864a02e8385a0c8becd269ea5 > > It is already applied there. > > Hmm, I am not seeing it : > > ani@ani-ubuntu:~/workspace/qemu-mst$ git show > 87bbbe87c259414864a02e8385a0c8becd269ea5 > fatal: bad object 87bbbe87c259414864a02e8385a0c8becd269ea5 > ani@ani-ubuntu:~/workspace/qemu-mst$ git branch -vv > master 7457fe9541 [origin/master] Update version for v1.7.0-rc2 release > * next e336a0d550 [origin/next] ack! hw/ide/piix: Ignore writes of > hardwired PCI command register bits
oh right. pushed now.
