On 05.01.2012, at 01:31, q...@buildbot.b1-systems.de wrote:
> The Buildbot has detected a new failure on builder default_ppc while building
> qemu.
> Full details are available at:
> http://buildbot.b1-systems.de/qemu/builders/default_ppc/builds/265
>
> Buildbot URL: http://buildbot.b1-systems.de/qemu/
>
> Buildslave for this Build: qemu-ppc.opensuse.org
>
> Build Reason: The Nightly scheduler named 'nightly_default' triggered this
> build
> Build Source Stamp: [branch master] HEAD
> Blamelist:
>
> BUILD FAILED: failed compile
cc1: warnings being treated as errors
/home/build/qemu/default_ppc/build/target-ppc/kvm.c: In function
'kvmppc_alloc_rma':
/home/build/qemu/default_ppc/build/target-ppc/kvm.c:825: error: passing
argument 3 of 'memory_region_init_ram_ptr' makes integer from pointer without a
cast
/home/build/qemu/default_ppc/build/target-ppc/kvm.c:825: error: passing
argument 4 of 'memory_region_init_ram_ptr' makes pointer from integer without a
cast
/home/build/qemu/default_ppc/build/target-ppc/kvm.c:825: error: too many
arguments to function 'memory_region_init_ram_ptr'
824 rma_region = g_new(MemoryRegion, 1);
825 memory_region_init_ram_ptr(rma_region, NULL, name, size, rma);
826 memory_region_add_subregion(sysmem, 0, rma_region);
commit c5705a7728b4a6bc9e4f2d35911adbaf28042b25
Author: Avi Kivity <a...@redhat.com>
Date: Tue Dec 20 15:59:12 2011 +0200
vmstate, memory: decouple vmstate from memory API
Currently creating a memory region automatically registers it for
live migration. This differs from other state (which is enumerated
in a VMStateDescription structure) and ties the live migration code
into the memory core.
Decouple the two by introducing a separate API, vmstate_register_ram(),
for registering a RAM block for migration. Currently the same
implementation is reused, but later it can be moved into a separate list,
and registrations can be moved to VMStateDescription blocks.
Signed-off-by: Avi Kivity <a...@redhat.com>
[...]
@@ -241,15 +237,11 @@ void memory_region_init_ram(MemoryRegion *mr,
* memory directly.
*
* @mr: the #MemoryRegion to be initialized.
- * @dev: a device associated with the region; may be %NULL.
- * @name: the name of the region; the pair (@dev, @name) must be globally
- * unique. The name is part of the save/restore ABI and so cannot be
- * changed.
+ * @name: the name of the region.
* @size: size of the region.
* @ptr: memory to be mapped; must contain at least @size bytes.
*/
void memory_region_init_ram_ptr(MemoryRegion *mr,
- DeviceState *dev, /* FIXME: layering violation
*/
const char *name,
uint64_t size,
void *ptr);
Avi, could you please grep through the code for potential users again and
change all of them when you see them?
Alex
