Hi Peter, On Tue, Oct 25, 2022 at 6:47 PM Peter Maydell <peter.mayd...@linaro.org> wrote: > So I didn't take this one patch, partly because I don't think
No problem - I'm actually quite happy to finally have this one reviewed. I'll send you a follow up. > all our supported build platforms have memmem(), and partly > because when I then looked a bit closer at it it looks like > we're searching through the whole blob for the RNG > seed. We know where it is to start with, so I think it would > be cleaner to have prom_set return table_addr (ie the offset > into the blob of what it just wrote) so we can use it here. > (You could also reverse-engineer it from prom_buf[prom_index - 1] > but returning the offset seems a bit less awkward.) You're right that the memmem is a bit lazy. I'll sort out a more direct way of doing it like I do for the other platforms. Jason
