On 24/10/22 23:42, Amarjargal Gundjalam wrote:
On 23/10/22 15:53, Volker Rümelin wrote:
Am 21.10.22 um 18:59 schrieb Amarjargal Gundjalam:
The TABs should be replaced with spaces, to make sure that we have a
consistent coding style with an indentation of 4 spaces everywhere.
Resolves:https://gitlab.com/qemu-project/qemu/-/issues/370
Reviewed-by: Daniel P. Berrangé<berra...@redhat.com>
Signed-off-by: Amarjargal Gundjalam<amarjarga...@gmail.com>
---
hw/audio/fmopl.c | 1664
++++++++++++++++++-------------------
hw/audio/fmopl.h | 138 +--
hw/audio/intel-hda-defs.h | 1008 +++++++++++-----------
hw/audio/wm8750.c | 270 +++---
4 files changed, 1540 insertions(+), 1540 deletions(-)
Hi Amarjargal,
I had a look at hw/audio/fmopl.c and I think the result doesn't look
right. A few comments are no longer correctly aligned. I guess you
just replaced all TABs with four spaces. But this is not how TABs work.
For reference: I used the vim command
:%s/^I/ /g
and the result is identical to your file. The commands
:se ts=4 expandtab
:retab
would have been a much better starting point for the last few manual
changes.
Here is another example. For the file hw/audio/wm8750.c I would have
started with the following vim commands
:se ts=8 expandtab
:retab
With best regards,
Volker
Hi Volker,
Thank you for your review!
Yes, I did indeed replaced all the tabs with spaces. I'll fix all of
them and update.
Best Regards,
Amarjargal
Hello again,
I redid the whole thing with vim retab and sent a new version of the
patches. I hope they're alright this time.
Thank you,
Amarjargal
