On Mon, Oct 17, 2022 at 08:21:37PM +0800, Bin Meng wrote: > +more people > > On Tue, Oct 11, 2022 at 6:42 PM Bin Meng <bmeng...@gmail.com> wrote: > > > > Hi Paolo, > > > > On Thu, Oct 6, 2022 at 11:03 AM Bin Meng <bmeng...@gmail.com> wrote: > > > > > > Hi Paolo, > > > > > > On Wed, Sep 28, 2022 at 2:10 PM Bin Meng <bmeng...@gmail.com> wrote: > > > > > > > > Hi Paolo, > > > > > > > > On Wed, Sep 21, 2022 at 9:02 AM Bin Meng <bmeng...@gmail.com> wrote: > > > > > > > > > > On Wed, Sep 14, 2022 at 4:08 PM Bin Meng <bmeng...@gmail.com> wrote: > > > > > > > > > > > > On Wed, Sep 7, 2022 at 1:07 PM Bin Meng <bmeng...@gmail.com> wrote: > > > > > > > It seems to me that resetting the event twice (one time with the > > > > > > > master Gsource, and the other time with the child GSource) causes > > > > > > > some > > > > > > > bizarre behavior. But MSDN [1] says > > > > > > > > > > > > > > "Resetting an event that is already reset has no effect." > > > > > > > > > > > > > > [1] > > > > > > > https://docs.microsoft.com/en-us/windows/win32/api/synchapi/nf-synchapi-resetevent > > > > > > > > > > > > > > > > > > > Paolo, any comments about this issue? > > > > > > > > > > v2 series has been sent out, and this patch remains unchanged. > > > > > > > > > > Paolo, still would appreciate your comments. > > > > > > > > Ping? > > > > > > Ping? Can you please comment?? > > > > Ping? > > Paolo remains silent. Please let me know who else could approve this > change. Thanks.
Given there has been plenty of time for objecting, I'll queue this patch on the basis that you've tested it on a real Windows host and found it better than what we have today. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|