On Fri, Oct 14, 2022 at 3:57 PM Alex Bennée <alex.ben...@linaro.org> wrote:
> I'm going to nominate Paolo for meson stuff given the conversion was
> his passion project.

It wasn't my passion project, it was my secret project to stop having
to fix bugs in the makefiles. :)

>  Build System
>  ------------
> +Meson
> +M: Paolo Bonzini <pbonz...@redhat.com>

I think it's fine leaving the handling of meson.build changes to the
community at large. Excluding my own changes to move stuff from
configure to meson.build (which I'm almost done with), the wide
majority of meson.build patches did not go through my tree.

But it's okay also to have me as the official maintainer, perhaps with
added reviewers. Among others Marc-André, Daniel, Thomas, Philippe all
contributed a lot of reviews and/or changes over the past two years.

> +S: Odd Fixes

S: Maintained

> +F: meson.build
> +F: meson_options.txt
> +F: scripts/meson-buildoptions.py

F: scripts/meson-buildoptions.*
F: scripts/check_sparse.py
F: scripts/entitlement.sh
F: scripts/symlink-install-tree.py
F: scripts/nsis.py

Looking at more files under scripts/, it's an easy cop out to add them
under the Meson entry but for example please add F:
scripts/feature_to_c.sh to gdbstub since you are at it. We also need
an entry for

F: include/qemu/module.h
F: util/module.c
F: scripts/modinfo-collect.py
F: scripts/modinfo-generate.py
F: scripts/undefsym.py

Perhaps Gerd?

> +TL Makefile and configure
> +R: Paolo Bonzini <pbonz...@redhat.com>
> +R: Alex Bennée <alex.ben...@linaro.org>
> +S: Odd Fixes

I think "M" is more appropriate, and "S: Maintained".

> +F: Makefile
> +F: configure

Also:

F: scripts/mtest2make.py
F: tests/Makefile.include

Another related change, given the recent cleanups to the tests/tcg Makefiles:

 Guest Test Compilation Support
 M: Alex Bennée <alex.ben...@linaro.org>
 R: Philippe Mathieu-Daudé <f4...@amsat.org>
 S: Maintained
-F: tests/tcg/Makefile
-F: tests/tcg/Makefile.include
+F: tests/tcg/Makefile.target

Thanks,

Paolo


Reply via email to