On Thu, Oct 13, 2022 at 9:26 PM Richard Henderson <richard.hender...@linaro.org> wrote: > On 10/14/22 07:52, Philippe Mathieu-Daudé wrote: > > + /* Sign extend the displacement with 21 bits. */ > > + delta = l & 0x1FFFFF; > > + if (delta & 0x100000) { > > + delta |= ~0x1FFFFF; > > + }
Note this follows the style of this file, ... > delta = sextract32(l, 0, 21); ... but I agree using sextract() makes it easier to review. I'll respin.