On Fri, 7 Oct 2022 at 16:27, Richard Henderson <richard.hender...@linaro.org> wrote: > > On 10/7/22 02:01, Peter Maydell wrote: > > The upcoming v8R support has its stage 2 attributes in the MAIR > > format, so it might be a little awkward to assume the v8A-stage-2 > > format here rather than being able to add the "if !is_s2_format" > > condition. I guess we'll deal with that when we get to it... > > Ah. I had wondered whether it would be better to convert the result here, so > that we > always have the MAIR format. I decided against it within the scope of this > patch set > because it meant that I kept the existing s1+s2 attribute merging logic > unchanged.
Unfortunately, for A-profile you can't just convert the s2 attrs to MAIR format, because their interpretation depends on the s1 attr values in the FWB case. So you have to keep the s2 attrs as raw until they get to the point of combination. (v8R doesn't have any equivalent of FWB.) thanks -- PMM
