On 11/29/2011 02:12 PM, Michael S. Tsirkin wrote:
On Tue, Nov 29, 2011 at 09:38:43AM +0100, Paolo Bonzini wrote:
On 11/28/2011 07:46 PM, Michael S. Tsirkin wrote:
+#ifdef CONFIG_LINUX
+static int virtio_9p_init_pci(PCIDevice *pci_dev)
+{
+ VirtIOPCIProxy *proxy = DO_UPCAST(VirtIOPCIProxy, pci_dev, pci_dev);
+ VirtIODevice *vdev;
+
+ vdev = virtio_9p_init(&pci_dev->qdev,&proxy->fsconf);
+ vdev->nvectors = proxy->nvectors;
+ virtio_init_pci(proxy, vdev);
+ /* make the actual value visible */
+ proxy->nvectors = vdev->nvectors;
+ return 0;
+}
+#endif
+
This ifdef looks wrong to me - is there no way 9p can thinkably
work on non-linux hosts? If yes, we should have a separate config
entry for 9p, configure script can make it
conditional on linux host.
I think it was true in the beginning, but more recent versions
should only depend on CONFIG_POSIX. I will set up FreeBSD and come
back.
Paolo
It might be easier to add CONFIG_VIRTIO_9P. That won't hurt in any case.
Actually CONFIG_VIRTFS exists already (Linux dependencies are mostly
statfs and d_off in struct dirent, plus extended attributes which are
checked separately).
Will resend.
Paolo
