On 10/3/22 03:28, Peter Maydell wrote:
I'd assumed you had a reason for using two bools rather than an enum in ARMVAParameters, so I left that alone :-)
I think it was because the existing code had variables of those names, so the patch changed "foo" to "param.foo". :-)
Putting GranuleSize into ARMVAParameters brings us into the area of enums in bitfields, where I'm not sure exactly what the standard says or our supported compilers allow as an impdef extension. GranuleSize gsize : 2; seems to work, but is it portable?
I think so. Leastwise, we use those elsewhere. I would certainly expect a warning from any of our supported compilers if we were to use too few bits for the enum type.
r~
