Re: [PATCH 2/2] target/m68k: use M68K_FEATURE_MOVEFROMSR_PRIV feature for move_from_sr privilege check

[Laurent Vivier]

Le 25/09/2022 à 15:48, Mark Cave-Ayland a écrit :

Now that M68K_FEATURE_M68000 has been renamed to M68K_FEATURE_M68K it is easier
to see that the privilege exception check is wrong: it is currently only 
generated
for ColdFire CPUs when in fact it should also be generated for Motorola CPUs 
from
the 68010 onwards.

Introduce a new M68K_FEATURE_MOVEFROMSR_PRIV feature which is set for all non-
Motorola CPUs, and for all Motorola CPUs from the 68010 onwards and use it to
determine whether a privilege exception should be generated for the MOVE-from-SR
instruction.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk>
Reviewed-by: Richard Henderson <richard.hender...@linaro.org>
---
  target/m68k/cpu.c       | 5 +++++
  target/m68k/cpu.h       | 2 ++
  target/m68k/translate.c | 2 +-
  3 files changed, 8 insertions(+), 1 deletion(-)

Applied to my m68k-for-7.2 branch

Thanks,
Laurent