On Samstag, 10. September 2022 19:46:55 CEST Christian Schoenebeck wrote: > This patch is pure refactoring, it does not change behaviour. > > virtio-9p-test.c grew to 1657 lines. Let's split this file up between > actual 9p test cases vs. 9p test client, to make it easier to > concentrate on the actual 9p tests. > > Move the 9p test client code to a new unit virtio-9p-client.c, which > are basically all functions and types prefixed with v9fs_* already. > > Note that some client wrapper functions (do_*) are preserved in > virtio-9p-test.c, simply because these wrapper functions are going to > be wiped with subsequent patches anyway. > > As the global QGuestAllocator variable is moved to virtio-9p-client.c, > add a new function v9fs_set_allocator() to be used by virtio-9p-test.c > instead of fiddling with a global variable across units and libraries. > > Signed-off-by: Christian Schoenebeck <qemu_...@crudebyte.com> > ---
I plan to queue this patch this week, if not hearing something back. It's the same code and behaviour anyway, just splitted to a seprate file. > As I am working on extending the previously sent RFC [1] (which will be > using function calls with named function arguments), I realized that it > makes sense to first split the client code out to a new file, and then > make the upcoming patches based on this patch here. Because that way > I don't have to touch the order of the client functions and the upcoming > patches will therefore become better readable. > > [1] https://lore.kernel.org/all/e1odqqv-0003d4...@lizzy.crudebyte.com/ > > tests/qtest/libqos/meson.build | 1 + > tests/qtest/libqos/virtio-9p-client.c | 683 +++++++++++++++++++++++ > tests/qtest/libqos/virtio-9p-client.h | 139 +++++ > tests/qtest/virtio-9p-test.c | 770 +------------------------- > 4 files changed, 849 insertions(+), 744 deletions(-) > create mode 100644 tests/qtest/libqos/virtio-9p-client.c > create mode 100644 tests/qtest/libqos/virtio-9p-client.h
