On 23/09/2022 03.09, Bin Meng wrote:
On Fri, Sep 23, 2022 at 3:32 AM Marc-André Lureau
<marcandre.lur...@gmail.com> wrote:
Hi
On Tue, Sep 20, 2022 at 1:48 PM Bin Meng <bmeng...@gmail.com> wrote:
From: Bin Meng <bin.m...@windriver.com>
Commit 413bebc04603 ("tests: Use g_mkdir_with_parents()") replaces
the mkdir() call in the test codes with glib's g_mkdir_with_parents(),
but the exact portable replacement for mkdir() should be g_mkdir().
I probably was misled by the GTK glib doc [1] before, thinking that
g_mkdir() is not a supported API from glib. But the glib sources do
not support this statement. It is probably that the GTK documentation
was not built to include all APIs.
[1] https://docs.gtk.org/glib/?q=mkdir
Fixes: 413bebc04603 ("tests: Use g_mkdir_with_parents()")
Signed-off-by: Bin Meng <bin.m...@windriver.com>
I wouldn't bother anymore, I'd keep mkdir_with_parents for now. YMMV
Yep but some maintainers pointed out in other patches in v1 that
g_mkdir() is the strict replacement for mkdir() :)
@Thomas Huth Would you share your thoughts?
It's a little bit weird that g_mkdir() does not show up in the glib docs ...
let's keep g_mkdir_with_parents(), that sounds like the better choice to me.
Thomas
