On Wed, Sep 21, 2022 at 05:51:33PM +0100, Dr. David Alan Gilbert wrote: > * Bin Meng (bmeng...@gmail.com) wrote: > > From: Bin Meng <bin.m...@windriver.com> > > > > Some migration test cases use TLS to communicate, but they fail on > > Windows with the following error messages: > > > > qemu-system-x86_64: TLS handshake failed: Insufficient credentials for > > that request. > > qemu-system-x86_64: TLS handshake failed: Error in the pull function. > > query-migrate shows failed migration: TLS handshake failed: Error in the > > pull function. > > > > Disable them temporarily. > > > > Signed-off-by: Bin Meng <bin.m...@windriver.com> > > --- > > I am not familar with the gnutls and simply enabling the gnutls debug > > output does not give me an immedidate hint on why it's failing on > > Windows. Disable these cases for now until someone or maintainers > > who may want to test this on Windows. > > Copying in Dan Berrange, he's our expert on weird TLS failures.
Seems to match this: https://gnutls.org/faq.html#key-usage-violation2 which suggests we have a configuration mis-match. I'm surprised to see you are only needing to disable the TLS PSK tests, not the TLS x509 tests. I'd like to know if tests/unit/test-crypto-tlssession passes. If so, it might suggest we are missing 'priority: NORMAL' property when configuring TLS creds for the migration test. > > (no changes since v1) > > > > tests/qtest/migration-test.c | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c > > index aedd9ddb72..dbee9b528a 100644 > > --- a/tests/qtest/migration-test.c > > +++ b/tests/qtest/migration-test.c > > @@ -1403,6 +1403,7 @@ static void test_precopy_unix_dirty_ring(void) > > } > > > > #ifdef CONFIG_GNUTLS > > +#ifndef _WIN32 > > static void test_precopy_unix_tls_psk(void) > > { > > g_autofree char *uri = g_strdup_printf("unix:%s/migsocket", tmpfs); > > @@ -1415,6 +1416,7 @@ static void test_precopy_unix_tls_psk(void) > > > > test_precopy_common(&args); > > } > > +#endif /* _WIN32 */ > > > > #ifdef CONFIG_TASN1 > > static void test_precopy_unix_tls_x509_default_host(void) > > @@ -1523,6 +1525,7 @@ static void test_precopy_tcp_plain(void) > > } > > > > #ifdef CONFIG_GNUTLS > > +#ifndef _WIN32 > > static void test_precopy_tcp_tls_psk_match(void) > > { > > MigrateCommon args = { > > @@ -1533,6 +1536,7 @@ static void test_precopy_tcp_tls_psk_match(void) > > > > test_precopy_common(&args); > > } > > +#endif /* _WIN32 */ > > > > static void test_precopy_tcp_tls_psk_mismatch(void) > > { > > @@ -1930,6 +1934,7 @@ static void test_multifd_tcp_zstd(void) > > #endif > > > > #ifdef CONFIG_GNUTLS > > +#ifndef _WIN32 > > static void * > > test_migrate_multifd_tcp_tls_psk_start_match(QTestState *from, > > QTestState *to) > > @@ -1937,6 +1942,7 @@ > > test_migrate_multifd_tcp_tls_psk_start_match(QTestState *from, > > test_migrate_precopy_tcp_multifd_start_common(from, to, "none"); > > return test_migrate_tls_psk_start_match(from, to); > > } > > +#endif /* _WIN32 */ > > > > static void * > > test_migrate_multifd_tcp_tls_psk_start_mismatch(QTestState *from, > > @@ -1988,6 +1994,7 @@ > > test_migrate_multifd_tls_x509_start_reject_anon_client(QTestState *from, > > } > > #endif /* CONFIG_TASN1 */ > > > > +#ifndef _WIN32 > > static void test_multifd_tcp_tls_psk_match(void) > > { > > MigrateCommon args = { > > @@ -1997,6 +2004,7 @@ static void test_multifd_tcp_tls_psk_match(void) > > }; > > test_precopy_common(&args); > > } > > +#endif /* _WIN32 */ > > > > static void test_multifd_tcp_tls_psk_mismatch(void) > > { > > @@ -2497,8 +2505,10 @@ int main(int argc, char **argv) > > qtest_add_func("/migration/precopy/unix/plain", > > test_precopy_unix_plain); > > qtest_add_func("/migration/precopy/unix/xbzrle", > > test_precopy_unix_xbzrle); > > #ifdef CONFIG_GNUTLS > > +#ifndef _WIN32 > > qtest_add_func("/migration/precopy/unix/tls/psk", > > test_precopy_unix_tls_psk); > > +#endif > > > > if (has_uffd) { > > /* > > @@ -2524,8 +2534,10 @@ int main(int argc, char **argv) > > > > qtest_add_func("/migration/precopy/tcp/plain", test_precopy_tcp_plain); > > #ifdef CONFIG_GNUTLS > > +#ifndef _WIN32 > > qtest_add_func("/migration/precopy/tcp/tls/psk/match", > > test_precopy_tcp_tls_psk_match); > > +#endif > > qtest_add_func("/migration/precopy/tcp/tls/psk/mismatch", > > test_precopy_tcp_tls_psk_mismatch); > > #ifdef CONFIG_TASN1 > > @@ -2569,8 +2581,10 @@ int main(int argc, char **argv) > > test_multifd_tcp_zstd); > > #endif > > #ifdef CONFIG_GNUTLS > > +#ifndef _WIN32 > > qtest_add_func("/migration/multifd/tcp/tls/psk/match", > > test_multifd_tcp_tls_psk_match); > > +#endif > > qtest_add_func("/migration/multifd/tcp/tls/psk/mismatch", > > test_multifd_tcp_tls_psk_mismatch); > > #ifdef CONFIG_TASN1 > > -- > > 2.34.1 > > > -- > Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK > With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
