On Tue, Sep 13, 2022 at 11:21:16AM -0700, Titus Rwantare wrote: > On Fri, 9 Sept 2022 at 12:58, Peter Delevoryas <pe...@pjd.dev> wrote: > > > > +/* > > > + * PECI Client device > > > + * Copyright 2021 Google LLC > > > + * > > > + * SPDX-License-Identifier: GPL-2.0-or-later > > > > Not sure, but I think the SPDX license identifier is supposed to be in > > the first line? Maybe not though. I would have expected: > > > > That's a Linux thing as far as I can tell. QEMU has it in the top comment.
Oh ok, nevermind then. > > > > > I'm curious if we really need the CPU family here, or if we could just > > base everything off the PECI version. > > > > The PECI specification doesn't mention the CPU family, does it? Or maybe > > it does. > > > > I needed the family info anyway for RdPkgConfig() CPU ID, and thought it > would be more readable to specify that in the board file than the PECI > version. > We tend to add new machines to QEMU by copying the config of an existing > machine, I think this way makes it more obvious that this is a field > that is changing. Yeah, I think you're right. And looking at the PECI spec, they refer to families directly when describing new features, so this seems appropriate. Reviewed-by: Peter Delevoryas <pe...@pjd.dev> > > > Titus
