On Fri, Sep 9, 2022 at 5:50 AM Dongwon Kim <dongwon....@intel.com> wrote:

> The scanout is currently updated only if the whole rect is inside the
> scanout space. This is not a correct condition because the scanout should
> be updated even a small area in the scanout space is covered by the rect.
>
> Cc: Gerd Hoffmann <kra...@redhat.com>
> Signed-off-by: Dongwon Kim <dongwon....@intel.com>
>

Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com>


> ---
>  hw/display/virtio-gpu.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c
> index 20cc703dcc..5e15c79b94 100644
> --- a/hw/display/virtio-gpu.c
> +++ b/hw/display/virtio-gpu.c
> @@ -515,9 +515,10 @@ static void virtio_gpu_resource_flush(VirtIOGPU *g,
>          for (i = 0; i < g->parent_obj.conf.max_outputs; i++) {
>              scanout = &g->parent_obj.scanout[i];
>              if (scanout->resource_id == res->resource_id &&
> -                rf.r.x >= scanout->x && rf.r.y >= scanout->y &&
> -                rf.r.x + rf.r.width <= scanout->x + scanout->width &&
> -                rf.r.y + rf.r.height <= scanout->y + scanout->height &&
> +                rf.r.x < scanout->x + scanout->width &&
> +                rf.r.x + rf.r.width >= scanout->x &&
> +                rf.r.y < scanout->y + scanout->height &&
> +                rf.r.y + rf.r.height >= scanout->y &&
>                  console_has_gl(scanout->con)) {
>                  dpy_gl_update(scanout->con, 0, 0, scanout->width,
>                                scanout->height);
> --
> 2.20.1
>
>
>

-- 
Marc-André Lureau

Reply via email to