On 08/09/2022 16.04, Marc-André Lureau wrote:
Hi
On Thu, Sep 8, 2022 at 5:33 PM Bin Meng <bmeng...@gmail.com
<mailto:bmeng...@gmail.com>> wrote:
From: Bin Meng <bin.m...@windriver.com <mailto:bin.m...@windriver.com>>
The sed processing of build/config-host.mak seems to be no longer
needed, and there is no such in the 32-bit build too. Drop it.
Signed-off-by: Bin Meng <bin.m...@windriver.com
<mailto:bin.m...@windriver.com>>
---
.gitlab-ci.d/windows.yml | 1 -
1 file changed, 1 deletion(-)
diff --git a/.gitlab-ci.d/windows.yml b/.gitlab-ci.d/windows.yml
index da6013904a..86a4339c48 100644
--- a/.gitlab-ci.d/windows.yml
+++ b/.gitlab-ci.d/windows.yml
@@ -60,7 +60,6 @@ msys2-64bit:
- $env:MSYS = 'winsymlinks:native' # Enable native Windows symlink
- .\msys64\usr\bin\bash -lc './configure --target-list=x86_64-softmmu
--enable-capstone --without-default-devices'
- - .\msys64\usr\bin\bash -lc "sed -i '/^ROMS=/d' build/config-host.mak"
It looks like it is there to remove the ROMS from the make build. No idea if
that still makes sense. Thomas, do you remember?
I originally had to add this sed statement since there was a compile error
otherwise in the ROMS ... if it now works fine without this line, this
should be fine, of course, too.
Reviewed-by: Thomas Huth <th...@redhat.com>
