Am 1. September 2022 11:41:14 UTC schrieb Bernhard Beschow <shen...@gmail.com>: >v5: > >* Add patch "Inline vt82c686b_southbridge_init() and remove it" (Zoltan) > >* Use machine parameter when creating rtc-time alias (Zoltan) > > > >Testing done: Same as in v3. > > > >v4: > >* Fix in comment: AC97 Modem -> MC97 Modem (Zoltan) > >* Introduce TYPE_VT82C686B_USB_UHCI define (Zoltan) > >* Introduce TYPE_VIA_IDE define (for consistency) > > > >v3: > >* Replace pre increment by post increment in for loop (Zoltan) > >* Move class defines close to where the class is defined (Zoltan) > > > >Testing done: > >* `make check-avocado` > > Passes for boot_linux_console.py for mips64el_fuloong2e > >* `qemu-system-ppc -machine pegasos2 -rtc base=localtime -device >ati-vga,guest_hwcursor=true,romfile="" -cdrom morphos-3.17.iso -kernel >morphos-3.17/boot.img` > > Boots successfully and it is possible to open games and tools. > > > >v2: > >* Keep the call to pci_ide_create_devs() in board code for consistency (Zoltan) > >* Create rtc-time alias in board rather than in south bridge code > >* Remove stale comments about PCI functions (Zoltan) > > > >v1: > >This series instantiates all PCI functions of the VT82xx south bridges in the >south bridges themselves. > >For the IDE function this is especially important since its interrupt routing >is configured in the > >ISA function, hence doesn't make sense to instantiate it as a "Frankenstein" >device. The interrupt > >routing is currently hardcoded and changing that is currently not in the scope >of this series. > > > >Testing done: > >* `qemu-system-ppc -machine pegasos2 -rtc base=localtime -device >ati-vga,guest_hwcursor=true,romfile="" -cdrom morphos-3.17.iso -kernel >morphos-3.17/boot.img` > > Boots successfully and it is possible to open games and tools. > > > >* I was unable to test the fuloong2e board even before this series since it >seems to be unfinished [1]. > > A buildroot-baked kernel [2] booted but doesn't find its root partition, > though the issues could be in the buildroot receipt I created. > > > >[1] https://osdn.net/projects/qmiga/wiki/SubprojectPegasos2 > >[2] https://github.com/shentok/buildroot/commits/fuloong2e >
Ping Zoltan, would you mind giving your Reviewed-by for 'hw/mips/fuloong2e: Inline vt82c686b_southbridge_init() and remove it' explicitly? Perhaps I was too eager to omit it since I didn't want to put words in your mouth. What else is missing? Who would do the pull request? Thanks, Bernhard > > >Bernhard Beschow (13): > > hw/isa/vt82c686: Resolve chip-specific realize methods > > hw/isa/vt82c686: Resolve unneeded attribute > > hw/isa/vt82c686: Prefer pci_address_space() over get_system_memory() > > hw/isa/vt82c686: Reuse errp > > hw/isa/vt82c686: Introduce TYPE_VIA_IDE define > > hw/isa/vt82c686: Instantiate IDE function in host device > > hw/isa/vt82c686: Introduce TYPE_VT82C686B_USB_UHCI define > > hw/isa/vt82c686: Instantiate USB functions in host device > > hw/isa/vt82c686: Instantiate PM function in host device > > hw/isa/vt82c686: Instantiate AC97 and MC97 functions in host device > > hw/mips/fuloong2e: Inline vt82c686b_southbridge_init() and remove it > > hw/isa/vt82c686: Embed RTCState in host device > > hw/isa/vt82c686: Create rtc-time alias in boards instead > > > > configs/devices/mips64el-softmmu/default.mak | 1 - > > hw/ide/via.c | 2 +- > > hw/isa/Kconfig | 1 + > > hw/isa/vt82c686.c | 120 +++++++++++++++---- > > hw/mips/fuloong2e.c | 39 +++--- > > hw/ppc/Kconfig | 1 - > > hw/ppc/pegasos2.c | 25 ++-- > > hw/usb/vt82c686-uhci-pci.c | 4 +- > > include/hw/isa/vt82c686.h | 4 +- > > 9 files changed, 126 insertions(+), 71 deletions(-) > > > >-- > >2.37.3 > > >
