On 20.12.2011, at 17:33, Peter Maydell wrote: > On 20 December 2011 16:29, Alexander Graf <ag...@suse.de> wrote: >> On 20.12.2011, at 17:17, Peter Maydell wrote: >>> On 14 December 2011 01:43, Alexander Graf <ag...@suse.de> wrote: >>>> +unsigned long reserved_va = 0xf7000000; >>> >>> So why 0xf7000000 rather than the whole of the 32 bit space? >>> >>> (In particular for ARM targets we want to be able to mmap >>> at 0xFFFFxxxx...) >> >> Because that didn't work for me. We still need the commpage >> above our reserved memory range, so this was the highest value >> that was safe for me. > > Hmm, that suggests we didn't get the interaction of the commpage > with the reserved range right -- the commpage is part of the > guest memory space so it should be OK for it to be inside > the reserved range.
That is very likely. Right now we take the reserved range and then put the commpage above it, not guaranteeing that nothing is there. I don't see what other way to do it if we want to be able to reserve less than all 32 bits of virtual address space (which might not be available!) Alex
