On Fri, Aug 19, 2022 at 6:35 PM Eugenio Perez Martin <epere...@redhat.com> wrote: > > On Fri, Aug 19, 2022 at 11:01 AM Jason Wang <jasow...@redhat.com> wrote: > > > > On Fri, Aug 19, 2022 at 4:30 PM Eugenio Perez Martin > > <epere...@redhat.com> wrote: > > > > > > On Fri, Aug 19, 2022 at 8:29 AM Jason Wang <jasow...@redhat.com> wrote: > > > > > > > > On Thu, Aug 11, 2022 at 2:42 AM Eugenio Pérez <epere...@redhat.com> > > > > wrote: > > > > > > > > > > This enable net/vdpa to restart the full device when a migration is > > > > > started or stopped. > > > > > > > > > > Signed-off-by: Eugenio Pérez <epere...@redhat.com> > > > > > > > > I have the following questions > > > > > > > > 1) any reason that we need to make this net specific? The dirty page > > > > tracking via shadow virtqueue is pretty general. And the net specific > > > > part was done via NetClientInfo anyhow. > > > > > > The listener is only used to know when migration is started / stopped, > > > no need for actual memory tracking. Maybe there is a better way to do > > > so? > > > > Not sure, SaveVMHandlers? > > > > I'm fine with investigating this, but the only entry in the doc says > it's the "legacy way". I assume the "modern way" is through > VMStateDescription, which is in virtio-net.
Right. > > The "pre_save" member already assumes the vhost backend is stopped, so > I'm not sure if this way is valid. I wonder if we can 1) new VhostOps 2) call that ops in vhost_log_gloabal_start/stop? Thanks
