On Tue, 16 Aug 2022, Cédric Le Goater wrote:
On 8/13/22 17:34, BALATON Zoltan wrote:
Hello,
This is mased on gitlab.com/danielhb/qemu/tree/ppc-7.2
This series contains the rest of Cédric's patches modified according
my review comments and some other small clean ups I've noticed along
the way. I've kept the From line of Cédric for patches that were
originally his even though they are modified a bit. Not sure what's
the best way for this or what Cédric prefers.
The last sdram changes are not yet here because I'm still looking at
those and will come back to them but this series is ready to merge
unless there are comments that need further changes. Please let me
know what do you think.
LGTM. In case you resend, may be change the names of the models which
are now common to PPC4xx. That's minor really.
I would dig the default case labels a little more before removing
them.
I've sent a v2 that includes the proposed name changes and dropped the
patch removing empty default cases for now. This v2 now also includes my
version of the sdram changes so that's all from me for now.
Regards,
BALATON Zoltan
Thanks,
C.
Regards,
BALATON Zoltan
BALATON Zoltan (22):
ppc/ppc4xx: Introduce a DCR device model
ppc/ppc405: QOM'ify CPC
ppc/ppc405: QOM'ify GPT
ppc/ppc405: QOM'ify OCM
ppc/ppc405: QOM'ify GPIO
ppc/ppc405: QOM'ify DMA
ppc/ppc405: QOM'ify EBC
ppc/ppc405: QOM'ify OPBA
ppc/ppc405: QOM'ify POB
ppc/ppc405: QOM'ify PLB
ppc/ppc405: QOM'ify MAL
ppc4xx: Move PLB model to ppc4xx_devs.c
ppc4xx: Move EBC model to ppc4xx_devs.c
ppc/ppc405: Use an embedded PPCUIC model in SoC state
hw/intc/ppc-uic: Convert ppc-uic to a PPC4xx DCR device
ppc/ppc405: Use an explicit I2C object
ppc/ppc405: QOM'ify FPGA
ppc405: Move machine specific code to ppc405_boards.c
hw/ppc/Kconfig: Remove PPC405 dependency from sam460ex
hw/ppc/Kconfig: Move imply before select
ppc4xx: Drop empty default cases
ppc/ppc4xx: Fix sdram trace events
hw/intc/ppc-uic.c | 26 +-
hw/ppc/Kconfig | 3 +-
hw/ppc/ppc405.h | 182 +++++--
hw/ppc/ppc405_boards.c | 360 +++++++++----
hw/ppc/ppc405_uc.c | 1071 ++++++++++++-------------------------
hw/ppc/ppc440_bamboo.c | 7 +-
hw/ppc/ppc440_uc.c | 27 -
hw/ppc/ppc4xx_devs.c | 473 +++++++++++++---
hw/ppc/sam460ex.c | 37 +-
hw/ppc/trace-events | 3 -
hw/ppc/virtex_ml507.c | 7 +-
include/hw/intc/ppc-uic.h | 6 +-
include/hw/ppc/ppc4xx.h | 71 ++-
13 files changed, 1223 insertions(+), 1050 deletions(-)
