On Tue, 16 Aug 2022 at 14:34, Alex Bennée <alex.ben...@linaro.org> wrote: > Peter Maydell <peter.mayd...@linaro.org> writes: > > Is there some place (in the superclass??) that we can put a > > default timeout that applies to *all* avocado tests, so we > > don't have the risk of forgetting it in a particular test? > > It's a bit muddy. Most tests are sub-classed on LinuxTest which does > define a default timeout: > > class LinuxTest(LinuxSSHMixIn, QemuSystemTest): > """Facilitates having a cloud-image Linux based available. > > For tests that indent to interact with guests, this is a better choice > to start with than the more vanilla `QemuSystemTest` class. > """ > > timeout = 900 > distro = None > username = 'root' > password = 'password' > smp = '2' > memory = '1024' > > However the aspeed tests are directly derived from QemuSystemTest. > Perhaps we should just move the timeout down to that or maybe > QemuBaseTest?
Ideally, we should do it at whatever level ensures it is applied to every single test that 'check-avocado' runs, regardless of how the test was written. "QemuBaseTest" still sounds a bit higher than the absolute basic "this is a test" level, but maybe that's the lowest level we have access to? thanks -- PMM
