From: Julian Pidancet <julian.pidan...@gmail.com> This recently added line in hw/pc_piix.c is causing a SEGV on a Xen setup because the piix3 property is never created:
qdev_property_add_child(qdev_resolve_path("/i440fx/piix3", NULL), "rtc", (DeviceState *)rtc_state, NULL); Signed-off-by: Julian Pidancet <julian.pidan...@gmail.com> Signed-off-by: Stefan Hajnoczi <stefa...@linux.vnet.ibm.com> --- hw/piix_pci.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/hw/piix_pci.c b/hw/piix_pci.c index d785d4b..ea156a9 100644 --- a/hw/piix_pci.c +++ b/hw/piix_pci.c @@ -324,9 +324,8 @@ static PCIBus *i440fx_common_init(const char *device_name, pci_create_simple_multifunction(b, -1, true, "PIIX3")); pci_bus_irqs(b, piix3_set_irq, pci_slot_get_pirq, piix3, PIIX_NUM_PIRQS); - - qdev_property_add_child(dev, "piix3", &piix3->dev.qdev, NULL); } + qdev_property_add_child(dev, "piix3", &piix3->dev.qdev, NULL); piix3->pic = pic; (*pi440fx_state)->piix3 = piix3; -- 1.7.7.3