On Thu, Aug 04, 2022 at 03:13:20PM +0200, Paolo Bonzini wrote: > Using a property makes it possible to use the normal compat property > mechanism instead of ad hoc code; it avoids parameter proliferation > in x86_load_linux; and allows shipping the code even if it is > disabled by default.
Strong NACK from me here. If this kind of thing is off by default, it's as good as useless. Indeed it shouldn't even be a knob at all. Don't do this. Rather, let's fix the bug. The code as-is -- going back to the 2016 DTB addition -- is problematic and needs to be fixed. So let's fix that. Trying to cover up the problem with a default-off knob just ensures this stuff will never be made to work right. Please do not commit this patch. Rather, let's see what a few round of review can do over on the fix I posted. We're still in rc0. No need to jump to something terrible like this. Jason
