On Tue, 28 Jun 2022 at 05:54, Richard Henderson <[email protected]> wrote: > > We were reporting unconditional success for these functions; > pass on any failure from cpu_memory_rw_debug. > > Reviewed-by: Peter Maydell <[email protected]> > Signed-off-by: Richard Henderson <[email protected]>
So, this commit makes us check the cpu_memory_rw_debug() return value in the softmmu_lock_user() function; but Coverity points out (CID 1490294) that we still aren't checking the return value from when we call it in softmmu_unlock_user()... What, if anything, should we do about that? In particular, I think that for semihosting calls that write to guest memory, if the guest passes us a pointer to read-only memory we're not going to find out about that until unlock time. thanks -- PMM
