On 7/26/22 21:06, Anup Patel wrote:
I see that decode_save_opc() only saves opcode in an array through tcg_set_insn_start_param(). Which brings me to the question about how much are we saving by distributing decode_save_opc() calls ?
It's not about tcg_set_insn_start_param(), but later when it is stored into the TranslationBlock -- see encode_search() in accel/tcg/translate-all.c.
If we distribute decode_save_opc() calls then the code becomes fragile for future changes and we will miss adding decode_save_opc() for some new extensions.
Perhaps the several percentage points of data savings are not significant enough to worry about.
r~
