On 7/19/22 15:00, Emanuele Giuseppe Esposito wrote:
Am 11/07/2022 um 15:08 schrieb Vladimir Sementsov-Ogievskiy:
That made me ask:
1. Are all tests always run in main loop? If yes, why to protect status
reading in test_complete_in_standby() ?
2. Maybe, we don't need to protect anything here? Why to protect other
things if we run everything in main loop?
I think it's still good example and practice to protect a function if it
needs to be protected and its name ends with _locked. It would just
confuse the reader if we don't protect it.
Agree. But still, I think we should be consistent in such decisions. If you don't
want to protect job->status in tests, then you shouldn't protect it in
test_complete_in_standby() as well, just to not confuse someone who read the code.
--
Best regards,
Vladimir
