On 12.07.22 23:19, Emanuele Giuseppe Esposito wrote:
child_job_change_aio_ctx() is very similar to
child_job_can_set_aio_ctx(), but it implements a new transaction
so that if all check pass, the new transaction's .commit()
will take care of changin the BlockJob AioContext.
child_job_set_aio_ctx_commit() is similar to child_job_set_aio_ctx(),
but it doesn't need to invoke the recursion, as this is already
taken care by child_job_change_aio_ctx().

Note: bdrv_child_try_change_aio_context() is not called by
anyone at this point.

Signed-off-by: Emanuele Giuseppe Esposito <eespo...@redhat.com>
---
  blockjob.c | 45 +++++++++++++++++++++++++++++++++++++++++++++
  1 file changed, 45 insertions(+)

Looks good, disregarding the fact that I’d like it very much if we could find some other primitive than tran_add_trail() to get these handlers to run on a drained graph.

But that’s taste (and something to talk about in patch 3), so I’ll just give a

Reviewed-by: Hanna Reitz <hre...@redhat.com>


Reply via email to