On Wed, Jul 13, 2022 at 02:31:08PM +0300, Konstantin Kostiuk wrote: > On Wed, Jul 13, 2022 at 1:38 PM Daniel P. Berrangé <berra...@redhat.com> > wrote: > > > On Wed, Jul 13, 2022 at 01:19:06PM +0300, Konstantin Kostiuk wrote: > > > Signed-off-by: Konstantin Kostiuk <kkost...@redhat.com> > > > Message-Id: <20220712092715.2136898-1-kkost...@redhat.com> > > > Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> > > > Signed-off-by: Konstantin Kostiuk <kkost...@redhat.com> > > > --- > > > MAINTAINERS | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > index 450abd0252..b1e73d99f3 100644 > > > --- a/MAINTAINERS > > > +++ b/MAINTAINERS > > > @@ -2880,6 +2880,7 @@ T: git https://repo.or.cz/qemu/armbru.git > > qapi-next > > > > > > QEMU Guest Agent > > > M: Michael Roth <michael.r...@amd.com> > > > +R: Konstantin Kostiuk <kkost...@redhat.com> > > > > This pull request contains functional changes under qga/, which > > suggests you're acting as a (co-)maintainer for QGA, not merely > > a reviewer. I wouldn't normally expect reviewers to send pull > > requests for a subsystem. As such should this be "M:", to > > indicate co-maintainership and have an explicit ACK from > > Michael Roth. > > > > As the maintainer of the Windows part of the Guest Agent, I have added > myself > as a reviewer so I don't miss out on general patches for the Guest Agent. > Some time ago, I asked Michael Roth if I could submit PRs for all guest > agent components and he allow me to do this. > If need I can add myself as a co-maintainer to Guest Agent not only > Guest Agent Windows.
It sounds like you're defacto a co-maintainer already then and might as well ackowledge this in MAINTAINERS. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
