On Wed, Dec 14, 2011 at 02:51:47PM +0100, Kevin Wolf wrote: > Am 13.12.2011 14:52, schrieb Stefan Hajnoczi: > > Signed-off-by: Stefan Hajnoczi <stefa...@linux.vnet.ibm.com> > > --- > > block_int.h | 83 > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > 1 files changed, 83 insertions(+), 0 deletions(-) > > Why are these functions static inline in the header instead of being > implemented in block.c?
You are right, they should be moved. > The other thing I was going to ask, but don't really know to which patch > I should reply, is whether we need to take care of bdrv_close/delete > while a block job is still running. What happens if you unplug a device > that is being streamed? Hotplug is protected by the bdrv_set_in_use() we issue during block job creation/completion. The 'change', 'resize', and 'snapshot_blkdev' operations are not protected AFAICT. I'll take a close look at them and send patches. Stefan
