Hi, > Originally, the command was a normal sync command and my understanding > is that it simply posted notification to the clients. Apparently, users > of the interface need to actually know when the client has Ack'd this > operation because otherwise it's racy since a disconnect may occur > before the client processes the redirection.
No. The problem is that qemu doesn't process any other I/O while a incoming migration is running, thats why we have to serialize things: First have spice client connect to the target (and wait for that op to finish). Then kick off live migration. That reminds me that there is another way to fix it: Simply lift the restriction to not process I/O while the incoming live migration runs, then the need to serialize goes away. What is the status here? I remember this being discussed in the past for other reasons. Also moving migration to a thread would probably easily allow the I/O thread run in parallel ... > The trouble with using a async command for this is that the time between > (1) & (2) may be arbitrarily long. Since most QMP clients today always > use a NULL tag, that effectively means the monitor is blocked for an > arbitrarily long time while this operation is in flight. There is a pretty short timeout (five seconds or so). cheers, Gerd
