Re: [PATCH] target/ppc/kvm: Skip ".." directory in kvmppc_find_cpu_dt

[Daniel Henrique Barboza]

On 7/11/22 16:37, Murilo Opsfelder Araujo wrote:

Some systems have /proc/device-tree/cpus/../clock-frequency. However,
this is not the expected path for a CPU device tree directory.

Signed-off-by: Murilo Opsfelder Araujo <muri...@linux.ibm.com>
Signed-off-by: Fabiano Rosas <faro...@linux.ibm.com>
---

Reviewed-by: Daniel Henrique Barboza <danielhb...@gmail.com>

  target/ppc/kvm.c | 6 ++++++
  1 file changed, 6 insertions(+)

diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c
index 6eed466f80..c8485a5cc0 100644
--- a/target/ppc/kvm.c
+++ b/target/ppc/kvm.c
@@ -1877,6 +1877,12 @@ static int kvmppc_find_cpu_dt(char *buf, int buf_len)
      buf[0] = '\0';
      while ((dirp = readdir(dp)) != NULL) {
          FILE *f;
+
+        /* Don't accidentally read from the upper directory */
+        if (strcmp(dirp->d_name, "..") == 0) {
+            continue;
+        }
+
          snprintf(buf, buf_len, "%s%s/clock-frequency", PROC_DEVTREE_CPU,
                   dirp->d_name);
          f = fopen(buf, "r");