On Tue, Jul 05, 2022 at 10:06:58AM +0200, Thomas Huth wrote: > On 28/06/2022 12.54, Daniel P. Berrangé wrote: > > There have been checks put into the migration test which skip it in a > > few scenarios > > > > * ppc64 TCG > > * ppc64 KVM with kvm-pr > > * s390x TCG > > > > In the original commits there are references to unexplained hangs in > > the test. There is no record of details of where it was hanging, but > > it is suspected that these were all a result of the max downtime limit > > being set at too low a value to guarantee convergance. > > > > Since a previous commit bumped the value from 1 second to 30 seconds, > > it is believed that hangs due to non-convergance should be eliminated > > and thus worth trying to remove the skipped scenarios. > > > > Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> > > --- > > tests/qtest/migration-test.c | 21 --------------------- > > 1 file changed, 21 deletions(-) > > I just gave this a try, and it's failing on my x86 laptop with the ppc64 > target: > > /ppc64/migration/auto_converge: qemu-system-ppc64: warning: TCG doesn't > support requested feature, cap-cfpc=workaround > qemu-system-ppc64: warning: TCG doesn't support requested feature, > cap-sbbc=workaround > qemu-system-ppc64: warning: TCG doesn't support requested feature, > cap-ibs=workaround > qemu-system-ppc64: warning: TCG doesn't support requested feature, > cap-ccf-assist=on > qemu-system-ppc64: warning: TCG doesn't support requested feature, > cap-cfpc=workaround > qemu-system-ppc64: warning: TCG doesn't support requested feature, > cap-sbbc=workaround > qemu-system-ppc64: warning: TCG doesn't support requested feature, > cap-ibs=workaround > qemu-system-ppc64: warning: TCG doesn't support requested feature, > cap-ccf-assist=on > Memory content inconsistency at df6000 first_byte = 98 last_byte = 98 > current = 2 hit_edge = 0 > Memory content inconsistency at 4e51000 first_byte = 98 last_byte = 97 > current = 96 hit_edge = 1 > Memory content inconsistency at 4e52000 first_byte = 98 last_byte = 97 > current = 96 hit_edge = 1 > Memory content inconsistency at 4e53000 first_byte = 98 last_byte = 97 > current = 96 hit_edge = 1 > Memory content inconsistency at 4e54000 first_byte = 98 last_byte = 97 > current = 96 hit_edge = 1 > Memory content inconsistency at 4e55000 first_byte = 98 last_byte = 97 > current = 96 hit_edge = 1 > Memory content inconsistency at 4e56000 first_byte = 98 last_byte = 97 > current = 96 hit_edge = 1 > Memory content inconsistency at 4e57000 first_byte = 98 last_byte = 97 > current = 96 hit_edge = 1 > Memory content inconsistency at 4e58000 first_byte = 98 last_byte = 97 > current = 96 hit_edge = 1 > Memory content inconsistency at 4e59000 first_byte = 98 last_byte = 97 > current = 96 hit_edge = 1 > and in another 5542 pages** > ERROR:../../devel/qemu/tests/qtest/migration-test.c:280:check_guests_ram: > assertion failed: (bad == 0) > Aborted (core dumped) > > So I guess this workaround was about a different issue and we should drop > this patch.
Yeah, at the very least needs for investigation. It is a little worrying though that we get such failures as it smells like a genuine bug that we've been missing from having tests disabled. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|