On 7/4/22 20:58, Peter Maydell wrote:
+ * Returns a pointer to the iotlb entry, with env_tlb(env)->c.lock
+ * still locked, for final additions to the iotlb entry. The caller
+ * must unlock the lock.
*/
-void tlb_set_page_with_attrs(CPUState *cpu, target_ulong vaddr,
- hwaddr paddr, MemTxAttrs attrs, int prot,
- int mmu_idx, target_ulong size)
+void tlb_set_page_with_extra(CPUState *cpu, target_ulong vaddr, hwaddr paddr,
+ MemTxAttrs attrs, PageEntryExtra extra,
+ int prot, int mmu_idx, target_ulong size)
The comment claims it returns a pointer to the iotlb entry, but
the code says it returns void... leftover from a previous design?
Whoops, yes. In the end I thought that was a bit too much internals exposed.
r~
