Re: [Qemu-devel] [PATCH 1/3] raw-posix: Remove dead code

[Andreas Färber]

Am 10.11.2011 19:40, schrieb Pavel Borzenkov:
> It was commented out since the initial import from svn.
> 
> Signed-off-by: Pavel Borzenkov <pavel.borzen...@gmail.com>

This dead code has just been picked up by Paolo for his "Support
mismatched host and guest logical block sizes" series (10/17).

Feel invited to test whether it works as expected on your Mac OS X.

Andreas

> ---
>  block/raw-posix.c |   18 ------------------
>  1 files changed, 0 insertions(+), 18 deletions(-)
> 
> diff --git a/block/raw-posix.c b/block/raw-posix.c
> index a3de373..17e1c6f 100644
> --- a/block/raw-posix.c
> +++ b/block/raw-posix.c
> @@ -37,7 +37,6 @@
>  #include <IOKit/storage/IOMediaBSDClient.h>
>  #include <IOKit/storage/IOMedia.h>
>  #include <IOKit/storage/IOCDMedia.h>
> -//#include <IOKit/storage/IOCDTypes.h>
>  #include <CoreFoundation/CoreFoundation.h>
>  #endif
>  
> @@ -279,23 +278,6 @@ static int raw_open(BlockDriverState *bs, const char 
> *filename, int flags)
>      return raw_open_common(bs, filename, flags, 0);
>  }
>  
> -/* XXX: use host sector size if necessary with:
> -#ifdef DIOCGSECTORSIZE
> -        {
> -            unsigned int sectorsize = 512;
> -            if (!ioctl(fd, DIOCGSECTORSIZE, &sectorsize) &&
> -                sectorsize > bufsize)
> -                bufsize = sectorsize;
> -        }
> -#endif
> -#ifdef CONFIG_COCOA
> -        uint32_t blockSize = 512;
> -        if ( !ioctl( fd, DKIOCGETBLOCKSIZE, &blockSize ) && blockSize > 
> bufsize) {
> -            bufsize = blockSize;
> -        }
> -#endif
> -*/
> -
>  /*
>   * Check if all memory in this vector is sector aligned.
>   */