On 29/06/2022 13:20, Markus Armbruster wrote:
Laurent Vivier <lviv...@redhat.com> writes:
Copied from socket netdev file and modified to use SocketAddress
to be able to introduce new features like unix socket.
"udp" and "mcast" are squashed into dgram netdev, multicast is detected
according to the IP address type.
"listen" and "connect" modes are managed by stream netdev. An optional
parameter "server" defines the mode (server by default)
Signed-off-by: Laurent Vivier <lviv...@redhat.com>
Reviewed-by: Stefano Brivio <sbri...@redhat.com>
---
[...]
...
+# @server: create server socket (default: true)
+#
+# Since: 7.1
+##
+{ 'struct': 'NetdevStreamOptions',
+ 'data': {
+ 'addr': 'SocketAddress',
+ '*server': 'bool' } }
+
+##
+# @NetdevDgramOptions:
+#
+# Configuration info for datagram socket netdev.
+#
+# @remote: remote address
+# @local: local address
+#
+# The code checks there is at least one of these options and reports an error
+# if not. If remote address is present and it's a multicast address, local
+# address is optional. Otherwise local address is required and remote address
+# is optional.
+#
+# Since: 7.1
+##
+{ 'struct': 'NetdevDgramOptions',
+ 'data': {
+ '*local': 'SocketAddress',
+ '*remote': 'SocketAddress' } }
Hard to see, but the space in "} }" is funny: it's U+00A0
(NO-BREAK-SPACE) encoded in UTF-8. Make it a plain old space, please.
I'm sorry, this happens sometime because I use a french macintosh keyboard, and to do '}'
I have to press alt+) and if I don't release fast enough 'alt' I produce an alt+space that
seems to generate this (invisible) character code...
(I've the same problem with '|' = alt+shift+l, but bash doesn't like it)
I'm updating the series with all your comments.
Thank you for the reviews.
Laurent
