On Wed, 22 Jun 2022 at 17:29, Jae Hyun Yoo <quic_jaeh...@quicinc.com> wrote: > > Hello, > > I'm sending a series to add Qualcomm BMC machines that are equipped with > Aspeed AST2600 SoC. Also, this series adds MAX31785 fan controller device > emulation. Please help to review.
Thanks for the MAX31785 model, that's handy to have. I'm all for more emulation and testing using Qemu models, but I wonder if you need to add all three of your boards. They seem to be a progression (evb-proto -> dc-scm -> firework). Could you get away with just one or two of those? > > Thanks, > > Jae > > Graeme Gregory (2): > hw/arm/aspeed: qcom-dc-scm-v1: add block backed FRU device > hw/arm/aspeed: add Qualcomm Firework machine and FRU device > > Jae Hyun Yoo (3): > hw/arm/aspeed: add support for the Qualcomm EVB proto board > hw/arm/aspeed: add support for the Qualcomm DC-SCM v1 board > hw/arm/aspeed: firework: add I2C MUXes for VR channels > > Maheswara Kurapati (4): > hw/i2c: pmbus: Page #255 is valid page for read requests. > hw/sensor: add Maxim MAX31785 device > hw/arm/aspeed: firework: Add MAX31785 Fan controllers > hw/arm/aspeed: firework: Add Thermal Diodes > > hw/arm/Kconfig | 1 + > hw/arm/aspeed.c | 158 +++++++++++- > hw/i2c/pmbus_device.c | 1 - > hw/sensor/Kconfig | 4 + > hw/sensor/max31785.c | 580 ++++++++++++++++++++++++++++++++++++++++++ > hw/sensor/meson.build | 1 + > 6 files changed, 742 insertions(+), 3 deletions(-) > create mode 100644 hw/sensor/max31785.c > > -- > 2.25.1 >
