On 20/06/2022 11.31, Zhang, Chen wrote:
-----Original Message-----
From: Thomas Huth <th...@redhat.com>
Sent: Friday, June 17, 2022 5:34 PM
To: Zhang, Chen <chen.zh...@intel.com>; Jason Wang
<jasow...@redhat.com>; qemu-dev <qemu-devel@nongnu.org>; Paolo
Bonzini <pbonz...@redhat.com>; Daniel P. Berrangé
<berra...@redhat.com>; Eduardo Habkost <edua...@habkost.net>; Eric
Blake <ebl...@redhat.com>; Markus Armbruster <arm...@redhat.com>
Cc: Peter Maydell <peter.mayd...@linaro.org>; Laurent Vivier
<lviv...@redhat.com>; Yuri Benditovich <yuri.benditov...@daynix.com>;
Andrew Melnychenko <and...@daynix.com>
Subject: Re: [RFC PATCH 12/12] test/qtest: Add ubpf basic test case
On 17/06/2022 09.36, Zhang Chen wrote:
TODO: This test case does not work. Need add ubpf.h header in qtest
compile "-I ../ubpf/vm -I ../ubpf/vm/inc".
I'm not sure if we need it in qtest. Because normal tests/qtest not
including external module test case like fdt. Or we just need a qtest
case for filter-ubpf module.
This test will load pre-compiled ebpf binary and run it in QEMU.
Signed-off-by: Zhang Chen <chen.zh...@intel.com>
---
[...]
Apart from the #include "libqtest.h" there is nothing related to qtest in
here ... should this maybe rather go into test/unit/ instead?
Rethink about it, I think you are right.
The only issue is can we involve submodule's header file in tests/unit?
I can't find meson/fdt/SLIRP test cases in the tests.
Well, the test should only be enabled in meson.build if the CONFIG_UBPF
switch is also enabled, then you can be sure that the header files of ubpf
are also available when it gets compiled.
Thomas
