On Wed, Jun 8, 2022 at 1:50 PM Stefan Hajnoczi <stefa...@redhat.com> wrote:
> Yes, that's fine. My main concern is that callers have been audited when
> errnos are changed. If you switch bdrv_{pread,pwrite}() to -EIO and have
> audited callers, then I'm happy.
>
> Consistent -EINVAL would be nice in the future, but I think it's lower
> priority and it doesn't have to be done any time soon.Great. I'll send a v4 with the small change to patch 06/10 that remains, and note in the email for this patch (07/10) that it required quite a bit of auditing. As mentioned, there were ~140 call sites, so I'm not positive I didn't make a mistake. Hopefully someone more accustomed to the code base will have enough time to double-check this.
