Am 11.12.2011 07:47, schrieb Brad Smith:
Public bug reported:
Looking at the OpenBSD buildbot logs I noticed a warning that appears
to be a bug in the code.
OpenBSD has a 32-bit time_t on all archs at the moment (32-bit and
64-bit).
CC i386-softmmu/monitor.o
/buildbot-qemu/default_openbsd_current/build/monitor.c: In function
'expire_password':
/buildbot-qemu/default_openbsd_current/build/monitor.c:944: warning:
overflow in implicit constant conversion
qemu-common.h has...
#ifndef TIME_MAX
#define TIME_MAX LONG_MAX
#endif
for OpenBSD this should be INT_MAX.
** Affects: qemu
Importance: Undecided
Status: New
This needs special handling for w32 / w64, too.
Looking at the code where TIME_MAX is used, I assume that
more fixes are needed. The following code for example
won't work:
if (lifetime > INT_MAX) {
What about using
#define TIME_FOREVER -1
instead of TIME_MAX? Of course this would need additional
code changes.
Regards,
Stefan Weil
