On Thu, Jun 9, 2022, at 12:09, Gerd Hoffmann wrote:
> Hi,
>
> > if (cpage > 4) {
> > fprintf(stderr, "cpage out of range (%u)\n", cpage);
> > + bytes = get_field(p->qtd.token, QTD_TOKEN_TBYTES);
> > + offset = p->qtd.bufptr[0] & ~QTD_BUFPTR_MASK;
> > + cpage = get_field(p->qtd.token, QTD_TOKEN_CPAGE);
> > + fprintf(stderr, "reading %u bytes from offset %u at page %u\n",
> > + bytes, offset, cpage);
>
> I think we should either drop it (you've successfully debugged the
> problem meanwhile, thanks for that), or turn it into a tracepoint.
> Simply printing to stderr is deprecated.
Gotcha, I'm OK with dropping it. Thanks for the feedback & queue-ing the fix!
Kind regards,
Arnout
