On Fri, Jun 3, 2022 at 9:38 PM Ani Sinha <a...@anisinha.ca> wrote: > > On an additional note, my changes are not backward compatible with > older compiler. The build will break when built with a centos 7 > docker/vm/host: > > /home/anisinha/workspace/bits/build/grub/grub-core/contrib-deps/python/Modules/_ctypes/_ctypes.c: > In function '_build_callargs': > /home/anisinha/workspace/bits/build/grub/grub-core/contrib-deps/python/Modules/_ctypes/_ctypes.c:3707:6: > error: empty declaration [-Werror] > __attribute__ ((fallthrough)); > ^ > /home/anisinha/workspace/bits/build/grub/grub-core/contrib-deps/python/Modules/_ctypes/_ctypes.c:3707:6: > error: ISO C90 forbids mixed declarations and code > [-Werror=declaration-after-statement] > /home/anisinha/workspace/bits/build/grub/grub-core/contrib-deps/python/Modules/_ctypes/_ctypes.c: > At top level: > cc1: error: unrecognized command line option > "-Wno-shift-negative-value" [-Werror] > cc1: error: unrecognized command line option "-Wno-cast-function-type" > [-Werror] > cc1: error: unrecognized command line option > "-Wno-address-of-packed-member" [-Werror] > cc1: error: unrecognized command line option > "-Wno-discarded-array-qualifiers" [-Werror]
I have fixed these. The code seems to build both on new and old compilers now. > > If fixing this is essential, we can ifdef some of these changes > between compiler version checks. > > On Fri, Jun 3, 2022 at 2:06 PM Ani Sinha <a...@anisinha.ca> wrote: > > > > Hi josh : > > Here are the pull requests. Please feel free to review and merge: > > > > Main bits module: > > https://github.com/biosbits/bits/pull/13 > > > > Submodules: > > https://github.com/biosbits/grub/pull/1 > > https://github.com/biosbits/python/pull/1 > > https://github.com/biosbits/libffi/pull/1 > > https://github.com/biosbits/fdlibm/pull/1 > > > > Thanks > > ani
