On 12/08/2011 09:38 AM, Kevin Wolf wrote:
Am 02.12.2011 21:20, schrieb Anthony Liguori:
Child properties express a relationship of composition.
Signed-off-by: Anthony Liguori<aligu...@us.ibm.com>
---
v1 -> v2
- fix comments (Kevin)
- add a reference when adding a child property (Kevin)
---
hw/qdev.c | 26 ++++++++++++++++++++++++++
hw/qdev.h | 20 ++++++++++++++++++++
2 files changed, 46 insertions(+), 0 deletions(-)
diff --git a/hw/qdev.c b/hw/qdev.c
index 2519f00..fa6b489 100644
--- a/hw/qdev.c
+++ b/hw/qdev.c
@@ -1174,6 +1174,32 @@ DeviceState *qdev_get_root(void)
return qdev_root;
}
+static void qdev_get_child_property(DeviceState *dev, Visitor *v, void *opaque,
+ const char *name, Error **errp)
+{
+ DeviceState *child = opaque;
+ gchar *path;
+
+ path = qdev_get_canonical_path(child);
+ visit_type_str(v,&path, name, errp);
+ g_free(path);
+}
+
+void qdev_property_add_child(DeviceState *dev, const char *name,
+ DeviceState *child, Error **errp)
+{
+ gchar *type;
+
+ type = g_strdup_printf("child<%s>", child->info->name);
+
+ qdev_property_add(dev, name, type, qdev_get_child_property,
+ NULL, NULL, child, errp);
+
+ qdev_ref(dev);
Shouldn't you increase the refcount for child rather than dev?
Indeed, I've fixed it in my tree. Thanks.
Regards,
Anthony Liguori
Kevin
