On 5/25/22 18:38, Alex Bennée wrote:
Richard Henderson <richard.hender...@linaro.org> writes:
On 5/25/22 05:29, Anton Johansson wrote:
For clarity's sake, here are the exact steps taken to produce this patch:
1. Update QEMU's libvirt-ci to the commit
https://gitlab.com/libvirt/libvirt-ci/-/commit/43927ff508e8ecb1ac225dabbc95b37c890db917
which adds flex/bison, and a native glib2 (required since
idef-parser
is a build-time tool.)
This must be split out -- submodule updates should be a patch by
themselves. Otherwise it can look like unintentional rebase breakage
(which, sadly, happens more often than legitimate submodule updates).
2. Copy in new `tests/lcitool/projects/qemu.yml` from `libvirt-ci`
3. run `tests/lcitool/refresh` to generate new docker/cirrus
files
And, yes, having one patch that's simply auto-generated is helpful.
To quote danpb:
danpb: should our tests/lcitool/projects/qemu.yml match the one in
the lcitool repo or are they different use cases?
<danpb> the one in libvirt-ci.git should be deleted really
<danpb> the one in qemu.git is the source of truth
so please just update the qemu.git qemu.yml for just what you need for
flex/bison without bringing in all the other (stale?) stuff.
r~
I see, thanks!
Just to make sure I understood you correctly, I should:
1. Make a standalone patch that updates libvirt-ci and runs
the refresh script, in case any package mappings changed
2. Change this patch to add flex/bison to QEMU's qemu.yml,
and run refresh
--
Anton Johansson,
rev.ng Labs Srl.
