On Wed, May 18, 2022 at 09:57:12AM +0100, Daniel P. Berrangé wrote: > > @@ -37,4 +37,8 @@ void migration_tls_channel_connect(MigrationState *s, > > QIOChannel *ioc, > > const char *hostname, > > Error **errp); > > + > > +/* Whether the QIO channel requires further TLS handshake? */ > > +bool migrate_channel_requires_tls(QIOChannel *ioc); > > I find this name somewhat confusing, as 'requires tls' and > 'uses tls' are just synonyms for the same thing IMHO. > > What this method is actually checking is whether we still need > to upgrade the channel from plain text to TLS, by completing a > TLS handshake. So can we call this: > > migrate_channel_requires_tls_upgrade
Sounds good. I'll wait for more comments on other patches. Thanks, -- Peter Xu
