On Mon, 16 May 2022 at 17:47, Richard Henderson <richard.hender...@linaro.org> wrote: > > On 5/16/22 08:46, Peter Maydell wrote: > > On Mon, 16 May 2022 at 16:43, Thomas Huth <th...@redhat.com> wrote: > >> > >> According to > >> > >> > >> https://lore.kernel.org/qemu-devel/20200921174118.39352-1-richard.hender...@linaro.org/ > >> > >> there was an issue with Capstone 3 from Ubuntu 18. Now that we removed > >> support for Ubuntu 18.04, that issue should hopefully not bite us > >> anymore. Compiling with version 3.0.5 seems to work fine on other > >> systems, so let's allow that version again. > > > > Commit bcf368626cb33c4d says the reason for requiring capstone > >> =4.0 was "We're about to use a portion of the 4.0 API", not > > "Ubuntu's specific capstone 3 is broken"... > > Looks like the patch to which this referred was never merged -- CS_ARCH_RISCV. > > I still have a branch with riscv support sitting in it, from Sep 2020. Sadly, > I never > posted that patch, nor said why I withheld it in the end. Perhaps the actual > riscv support > in capstone was poor at the time. > > The 4.0 requirement patch itself was kept for Ubuntu 18's issue: > > https://lists.gnu.org/archive/html/qemu-devel/2020-09/msg07542.html
Is that this one? https://lore.kernel.org/qemu-devel/87wo0no0wz....@linaro.org/ Did we find out why Ubuntu's capstone in particular fell over ? thanks -- PMM
