On Thu, May 12 2022, Alex Williamson <alex.william...@redhat.com> wrote:
> On Thu, 12 May 2022 18:43:13 +0300 > Avihai Horon <avih...@nvidia.com> wrote: > >> @@ -767,9 +767,10 @@ static void vfio_migration_state_notifier(Notifier >> *notifier, void *data) >> case MIGRATION_STATUS_CANCELLED: >> case MIGRATION_STATUS_FAILED: >> bytes_transferred = 0; >> - ret = vfio_migration_set_state(vbasedev, >> - ~(VFIO_DEVICE_STATE_SAVING | >> VFIO_DEVICE_STATE_RESUMING), >> - VFIO_DEVICE_STATE_RUNNING); >> + ret = vfio_migration_set_state( >> + vbasedev, >> + ~(VFIO_DEVICE_STATE_V1_SAVING | VFIO_DEVICE_STATE_V1_RESUMING), >> + VFIO_DEVICE_STATE_V1_RUNNING); > > Yikes! Please follow the line wrapping used elsewhere. There's no need > to put the first arg on a new line and subsequent wrapped lines should > be indented to match the previous line, or at least to avoid wrapping > itself. Here we can use something like: > > ret = vfio_migration_set_state(vbasedev, > ~(VFIO_DEVICE_STATE_V1_SAVING | > VFIO_DEVICE_STATE_V1_RESUMING), > VFIO_DEVICE_STATE_V1_RUNNING); FWIW, I'd prefer this variant as well.
