On Thu, May 05, 2022 at 04:39:35PM +0100, Stefan Hajnoczi wrote: > On Tue, May 03, 2022 at 10:16:47AM -0400, Jagannathan Raman wrote: > > diff --git a/subprojects/libvfio-user b/subprojects/libvfio-user > > new file mode 160000 > > index 0000000000..030d2f6e79 > > --- /dev/null > > +++ b/subprojects/libvfio-user > > @@ -0,0 +1 @@ > > +Subproject commit 030d2f6e7978b8ca7577b81d4f48e2771bcd8f47 > > diff --git a/tests/docker/dockerfiles/centos8.docker > > b/tests/docker/dockerfiles/centos8.docker > > index 4b20925bbf..300833d8e0 100644 > > --- a/tests/docker/dockerfiles/centos8.docker > > +++ b/tests/docker/dockerfiles/centos8.docker > > @@ -23,6 +23,7 @@ RUN dnf update -y && \ > > capstone-devel \ > > ccache \ > > clang \ > > + cmake \ > > Good, CentOS 8 has CMake 3.20.0. > > > diff --git a/tests/docker/dockerfiles/ubuntu2004.docker > > b/tests/docker/dockerfiles/ubuntu2004.docker > > index a3b38884e3..7c6131686a 100644 > > --- a/tests/docker/dockerfiles/ubuntu2004.docker > > +++ b/tests/docker/dockerfiles/ubuntu2004.docker > > @@ -18,6 +18,7 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ > > ca-certificates \ > > ccache \ > > clang \ > > + cmake \ > > Ubuntu 20.04LTS has CMake 3.16.3: > https://packages.ubuntu.com/focal/cmake > > That does not meet the minimum version requirement in this patch series > (3.19.0). > > Please re-run container build to check if Ubuntu actually works. > > Hopefully libvfio-user will support meson and CMake can be dropped from > this patch series.
That's something I have proposed here: https://github.com/nutanix/libvfio-user/pull/666 With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
