>If other projects want to borrow bits of QEMU code then >they need to either (a) abide by our conventions for >what compiler warnings to enable or disable, or else >(b) fork the code and fiddle with their own copy. Agreed, it's not a huge deal if a single add_project_arguments call is duplicated across a couple meson subprojects. Paolo > >I don't really want to see QEMU's source code get littered >with a pile of extra macros hiding diagnostic pragmas. >(If we stop passing -Wno-initializer-overrides to the >compiler then we set a bunch of new "built on gcc on the >developer's machine but fails to build on clang in the >CI jobs" traps for ourselves, and if we don't stop passing >that then the places that should be marked up with the >macros won't reliably be marked up.) > >thanks >-- PMM >
- [PATCH 00/16] Misc cleanups marcandre . lureau
- [PATCH 01/16] include: move qemu_*_exec_dir() to c... marcandre . lureau
- [PATCH 03/16] tests: make libqmp buildable for win... marcandre . lureau
- [PATCH 08/16] osdep: export qemu_open_cloexec() marcandre . lureau
- [PATCH 04/16] compiler.h: add QEMU_{BEGIN, END}_IG... marcandre . lureau
- Re: [PATCH 04/16] compiler.h: add QEMU_{BEGIN,... Peter Maydell
- Re: [PATCH 04/16] compiler.h: add QEMU_{BE... Paolo Bonzini
- [PATCH 02/16] util/win32: simplify qemu_get_local_... marcandre . lureau
- Re: [PATCH 02/16] util/win32: simplify qemu_ge... Stefan Weil via
- [PATCH 05/16] qobject/json-lexer: disable -Winitia... marcandre . lureau
- [PATCH 16/16] qga/wixl: replace QEMU_GA_MSI_MINGW_... marcandre . lureau
- [PATCH 06/16] include: adjust header guards after ... marcandre . lureau
- Re: [PATCH 06/16] include: adjust header guard... Stefan Weil via
- [PATCH 10/16] qapi/error: add g_autoptr(Error) sup... marcandre . lureau
- Re: [PATCH 10/16] qapi/error: add g_autoptr(Er... Paolo Bonzini
- [PATCH 07/16] qga: flatten safe_open_or_create() marcandre . lureau
- [PATCH 09/16] qga: use qemu_open_cloexec() for saf... marcandre . lureau